fix(auth): bypass client-side router with native window redirect - #101
Merged
Conversation
- Replace Astro client-side `Maps` with native `window.location.assign` - Isolate production routing pipeline from SPA script deferral or Rocket Loader interference - Remove unused `Maps` import from `astro:transitions/client`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR resolves a client-side navigation bottleneck where the production runtime failed to execute smooth-state navigation after a successful login hook resolution. It safely falls back to a clean, browser-native redirection approach.
Key Changes:
Maps()utility with a native browserwindow.location.assign("/dashboard")initialization. This isolates the redirection sequence from potential edge script deferral, caching mismatches, or Cloudflare optimization overrides (e.g., Rocket Loader).Mapsfunction dependency import fromastro:transitions/client.Fixes # (issue number)
🧪 Type of Change
🛠️ How Has This Been Tested?
Deployed and validated that browser form states successfully execute a complete hard redirect cycle directly into the authenticated route upon receipt of a valid backend payload response.
Inspected development and production builds to ensure no lingering dependency type errors remain.
Unit/Integration tests added/passed
Local manual edge verification successful
📸 Screenshots / Diffs (if applicable)
Modified File:
src/modules/auth/auth.hooks.ts✅ Checklist